Pages: 1 [2] 3 :: one page |
|
Author |
Thread Statistics | Show CCP posts - 11 post(s) |
Thoirdhealbhach
Liga der hessischen Gentlemen
23
|
Posted - 2017.02.15 21:35:27 -
[31] - Quote
Elegbara wrote:Fascinating read.
Also I've actually tried to read the code and there's definitely something wrong in the Synchro::Tick snippet. The for loop seems corrupted.
Yep, seems like the last third of the for command got eaten up during copy&paste.
Anyhow, my sympathies, I've been chasing some bad reference counting myself for the better part of last month. |
Sentient Blade
Crisis Atmosphere Coalition of the Unfortunate
1805
|
Posted - 2017.02.15 21:43:39 -
[32] - Quote
Sentient Blade wrote:All the same, pretty nasty.
Oops. Just quoting myself as when I was reading through this again I realised my "pretty nasty" comment could be taken incorrectly.
I meant it was a pretty nasty bug. |
|
CCP karkur
C C P C C P Alliance
4093
|
Posted - 2017.02.15 22:20:48 -
[33] - Quote
Kolmogorow wrote:Thanks for sharing this! I didn't understand a lot of the details but what catched me at the end was that this bug might also have been the issue of "the overview not updating". That one I know well, as long as I play, which is long. Over the years I sometimes thought, this bug is annoying, why don't they care? I understand better now, it's not about ignoring a bug, but finding a very deep and hidden bug that is difficult to reproduce and to analyze in a complex code base. Software development is a human task, and it's not bad to sometimes show failure and success in the struggle against the single byte that doesn't do what you want it to do.
We are pretty sure this bug has been causing some overview issues, but there might very well be other issues that remain, but we are happy to get this at least out of the way
Over the years, we have spent a lot of time on overview and HUD issues, reading the code, trying to repro, adding logging but not gotten very far with it. It's especially tricky because we often don't know what else people have been doing when those weird things happen or what else had been happening. The drone case was similar, we knew it was happening but just couldn't repro it ourselves. We had spent days on looking into it (not ignoring it like many thought), but based on reports and videos we had, we saw details in the drone window (what had and had not updated) that made no sense, the code just "couldn't" fail in that way. But the good thing about the drone bug was that we had a decent idea under what circumstance it happened, so I ended up just sitting down, determined to repro like players were reporting... yeah, it probably took me like an hour and half to break it for the first time, but well worth in the end
CCP karkur | Programmer | Team Five 0 | @CCP_karkur
|
|
Gilion Braveheart
Ascendance Goonswarm Federation
4
|
Posted - 2017.02.15 22:58:00 -
[34] - Quote
What?!? A game company ok with sharing code?!? *gasp* I have to say I was kinda surprised, I've been trying to teach myself game design and while I've only done simple coding problems, I always though games as complex as EVE would have equally complex code, but the code shown looks nice and simple. Maybe there's hope for me yet :) |
Illiana ShadowGlade
Caldari Provisions Caldari State
3
|
Posted - 2017.02.15 23:03:32 -
[35] - Quote
This was an awesome read. I did IT in high school and got paid to run the the servers there over the summers after I graduated and trying to find code was always a pain.
Have you guys tried using the rubber ducky method? Grab a rubber ducky. Sit it on your desk/keyboard what have you... Explain to the duck the code. Two or three times if you have to. Eventually it'll hit you like a truck and you will probably throw the duck across the room because the 'stupid complex problem' has a simple solution, or it's something you never second guessed until that duck just gives you it's dead placid stare. |
Specific Alduin
Altair Omega Industries
1
|
Posted - 2017.02.15 23:14:17 -
[36] - Quote
I have been having this problem so much recently, I am ecstatic that it finally got fixed!!! |
Kolmogorow
Freedom Resources
348
|
Posted - 2017.02.15 23:25:37 -
[37] - Quote
CCP karkur wrote:We are pretty sure this bug has been causing some overview issues, but there might very well be other issues that remain, but we are happy to get this at least out of the way Over the years, we have spent a lot of time on overview and HUD issues, reading the code, trying to repro, adding logging but not gotten very far with it. It's especially tricky because we often don't know what else people have been doing when those weird things happen or what else had been happening. The drone case was similar, we knew it was happening but just couldn't repro it ourselves. We had spent days on looking into it (not ignoring it like many thought), but based on reports and videos we had, we saw details in the drone window (what had and had not updated) that made no sense, the code just "couldn't" fail in that way. But the good thing about the drone bug was that we had a decent idea under what circumstance it happened, so I ended up just sitting down, determined to repro like players were reporting... yeah, it probably took me like an hour and half to break it for the first time, but well worth in the end
You and your team deserve an extra beer now, or two. |
Taryn Earendil
The Kronos Ritual
0
|
Posted - 2017.02.16 01:40:00 -
[38] - Quote
I am a C++ newb. When I'm doing systems stuff, I use Rust. Mostly, because I'm into being a hipster developer...... but my question is with this RemoveSleeper function:
void Synchro::RemoveSleeper( Heap &sleepers, Sleeper &sl ) { SleeperIt it; for( it = sleepers.begin(); it != sleepers.end(); ++it ) { if( it->channel == sl.channel ) { break; } } if( it != sleepers.end() ) { //Ok found us. Let's delete us. sleepers.Remove( it ); Py_DECREF( sl.channel ); } }
Would this be a more succint way to do it?
void Synchro::RemoveSleeper( Heap &sleepers, Sleeper &sl ) { SleeperIt it; for( it = sleepers.begin(); it != sleepers.end(); ++it ) { if( it->channel == sl.channel ) { //Ok found us. Let's delete us. sleepers.Remove( it ); Py_DECREF( sl.channel ); break; } } } |
TheSmokingHertog
Julia's Interstellar Trade Emperium
452
|
Posted - 2017.02.16 04:30:35 -
[39] - Quote
07
"Dogma is kind of like quantum physics, observing the dogma state will change it." ~ CCP Prism X
"Schrödinger's Missile. I dig it." ~ Makari Aeron
-= "Brain in a Box on Singularity" - April 2015 =-
|
Branquinha
30plus Fidelas Constans
0
|
Posted - 2017.02.16 08:13:20 -
[40] - Quote
(slow clap) (/bows to magnificence of analysis)
You must have felt pretty good after that one!
Just out of curiosity, aprox how many hours until you found it? And how many "I'm not finding anything breaks!" ?
|
|
|
CCP Snorlax
C C P C C P Alliance
1181
|
Posted - 2017.02.16 10:18:46 -
[41] - Quote
Taryn Earendil wrote:I am a C++ newb. When I'm doing systems stuff, I use Rust. Mostly, because I'm into being a hipster developer...... but my question is with this RemoveSleeper function: void Synchro::RemoveSleeper( Heap &sleepers, Sleeper &sl ) { SleeperIt it; for( it = sleepers.begin(); it != sleepers.end(); ++it ) { if( it->channel == sl.channel ) { break; } } if( it != sleepers.end() ) { //Ok found us. Let's delete us. sleepers.Remove( it ); Py_DECREF( sl.channel ); } } Would this be a more succint way to do it? void Synchro::RemoveSleeper( Heap &sleepers, Sleeper &sl ) { SleeperIt it; for( it = sleepers.begin(); it != sleepers.end(); ++it ) { if( it->channel == sl.channel ) { //Ok found us. Let's delete us. sleepers.Remove( it ); Py_DECREF( sl.channel ); break; } } } Yeah, sure, but in this case I omitted some code that was irrelevant to the example.
CCP Snorlax - Software Architect - Team RnB - @CCP_Snorlax - http://ccpsnorlax.blogspot.is/
|
|
|
CCP Snorlax
C C P C C P Alliance
1181
|
Posted - 2017.02.16 10:20:49 -
[42] - Quote
Thoirdhealbhach wrote:Elegbara wrote:Fascinating read.
Also I've actually tried to read the code and there's definitely something wrong in the Synchro::Tick snippet. The for loop seems corrupted. Yep, seems like the last third of the for command got eaten up during copy&paste. Anyhow, my sympathies, I've been chasing some bad reference counting myself for the better part of last month. It seems that a portion of the code looked similar to HTML so the content management system swallowed it - it's been fixed now.
CCP Snorlax - Software Architect - Team RnB - @CCP_Snorlax - http://ccpsnorlax.blogspot.is/
|
|
|
CCP Snorlax
C C P C C P Alliance
1181
|
Posted - 2017.02.16 10:23:10 -
[43] - Quote
Branquinha wrote:(slow clap) (/bows to magnificence of analysis) You must have felt pretty good after that one! Just out of curiosity, aprox how many hours until you found it? And how many "I'm not finding anything breaks!" ? I don't know how long CCP karkur had spent on this, but after she'd basically proven in had to be in the Sleep command, I spent 3 solid working days on this, much of that in a staring contest with the code...
CCP Snorlax - Software Architect - Team RnB - @CCP_Snorlax - http://ccpsnorlax.blogspot.is/
|
|
|
CCP Snorlax
C C P C C P Alliance
1181
|
Posted - 2017.02.16 10:23:54 -
[44] - Quote
Illiana ShadowGlade wrote:This was an awesome read. I did IT in high school and got paid to run the the servers there over the summers after I graduated and trying to find code was always a pain.
Have you guys tried using the rubber ducky method? Grab a rubber ducky. Sit it on your desk/keyboard what have you... Explain to the duck the code. Two or three times if you have to. Eventually it'll hit you like a truck and you will probably throw the duck across the room because the 'stupid complex problem' has a simple solution, or it's something you never second guessed until that duck just gives you it's dead placid stare. I used a colleague instead. I refrained from throwing him across the room.
CCP Snorlax - Software Architect - Team RnB - @CCP_Snorlax - http://ccpsnorlax.blogspot.is/
|
|
Katrina Bekers
Pandemic Horde Inc. Pandemic Horde
263
|
Posted - 2017.02.16 11:09:34 -
[45] - Quote
CCP Snorlax wrote:I used a colleague instead. I refrained from throwing him across the room. Poor Guard!!!
Anyway, CCP Snorlax proves once and again to be one of the best devs of our favorite icelandic software house.
Can't wait for his roundtables at Fanfest.
<< THE RABBLE BRIGADE >>
|
Tonto Auri
Vhero' Multipurpose Corp
264
|
Posted - 2017.02.16 14:55:26 -
[46] - Quote
I'm wondering though. Do C++ supports the concept of destructors? In a language that does, I would place all cleanup code in a destructor and call it a day. Especially service objects cleanup.
Two most common elements in the universe are hydrogen and stupidity.
-- Harlan Ellison
|
|
CCP Snorlax
C C P C C P Alliance
1192
|
Posted - 2017.02.16 15:02:41 -
[47] - Quote
Tonto Auri wrote:I'm wondering though. Do C++ supports the concept of destructors? In a language that does, I would place all cleanup code in a destructor and call it a day. Especially service objects cleanup. Sure, but the Python C API is just that - a C API, not a C++ API.
CCP Snorlax - Software Architect - Team RnB - @CCP_Snorlax - http://ccpsnorlax.blogspot.is/
|
|
Sentient Blade
Crisis Atmosphere Coalition of the Unfortunate
1807
|
Posted - 2017.02.16 16:05:02 -
[48] - Quote
CCP Snorlax wrote:Tonto Auri wrote:I'm wondering though. Do C++ supports the concept of destructors? In a language that does, I would place all cleanup code in a destructor and call it a day. Especially service objects cleanup. Sure, but the Python C API is just that - a C API, not a C++ API.
https://s-media-cache-ak0.pinimg.com/564x/ff/88/21/ff8821dda34f16b946434236505df4ca.jpg
Don't be silly, wrap your... C resource types inside reference countered pointers with suitable encapsulation. |
dirtycasual
Red Federation RvB - RED Federation
0
|
Posted - 2017.02.16 16:23:08 -
[49] - Quote
Katherine Hakoke wrote:This is quite possibly the only MMO I know of that is willing to get technical and actually talk about what is going on.
<3 CCP |
FearlessLittleToaster
GoonWaffe Goonswarm Federation
177
|
Posted - 2017.02.16 17:10:07 -
[50] - Quote
With this bug fixed can you work on the one that makes my ships explode when I undock drunk? I've reproduced it nearly 100% of the time when the conditions exist... |
|
Captain Campion
Campion Corp.
39
|
Posted - 2017.02.16 17:57:58 -
[51] - Quote
It's running a ton better now, great work. |
Lors Dornick
Kallisti Industries Solar Assault Fleet
1205
|
Posted - 2017.02.16 18:34:46 -
[52] - Quote
FearlessLittleToaster wrote:With this bug fixed can you work on the one that makes my ships explode when I undock drunk? I've reproduced it nearly 100% of the time when the conditions exist... For them to be able to reproduce this accurately you'll have to provide a serious amount (they are Icelandic after all) of alcohol with your bug report.
CCP Greyscale: As to starbases, we agree it's pretty terrible, but we don't want to delay the entire release just for this one factor.
|
|
CCP Snorlax
C C P C C P Alliance
1201
|
Posted - 2017.02.16 18:51:51 -
[53] - Quote
FearlessLittleToaster wrote:With this bug fixed can you work on the one that makes my ships explode when I undock drunk? I've reproduced it nearly 100% of the time when the conditions exist... I always get a headache when trying to reproduce the bug.
CCP Snorlax - Software Architect - Team RnB - @CCP_Snorlax - http://ccpsnorlax.blogspot.is/
|
|
Cristl
533
|
Posted - 2017.02.16 20:02:05 -
[54] - Quote
CCP Snorlax wrote:FearlessLittleToaster wrote:With this bug fixed can you work on the one that makes my ships explode when I undock drunk? I've reproduced it nearly 100% of the time when the conditions exist... I always get a headache when trying to reproduce the bug. Heh, nice! |
Gaius Ambramotte
Fistful of Finns WE FORM V0LTA
0
|
Posted - 2017.02.17 07:23:28 -
[55] - Quote
In your example code was a syntax error as far I understand C++:
if (sleepers.size()) { Be::Time nnow = BeOS->GetActualTime(); for(unsigned int i = 0; iPyError(); } <---- "}" should be " ) {" Py_DECREF(s.channel); } }
|
|
CCP Snorlax
C C P C C P Alliance
1209
|
Posted - 2017.02.17 09:22:12 -
[56] - Quote
Gaius Ambramotte wrote:In your example code was a syntax error as far I understand C++:
if (sleepers.size()) { Be::Time nnow = BeOS->GetActualTime(); for(unsigned int i = 0; iPyError(); } <---- "}" should be " ) {" Py_DECREF(s.channel); } }
The CMS messed with the formatting of the code segments, resulting in some of it disappearing. It's been fixed now.
CCP Snorlax - Software Architect - Team RnB - @CCP_Snorlax - http://ccpsnorlax.blogspot.is/
|
|
RaVenC
Kriegsmarinewerft Goonswarm Federation
12
|
Posted - 2017.02.17 16:42:57 -
[57] - Quote
And still endless loops when "begin" is greater than "end" by [insert random issue here] |
MeagerMiner
11
|
Posted - 2017.02.17 22:03:43 -
[58] - Quote
I never get tired of hearing and seeing how dedicated our Devs work to keep us flying space ships around!
Appreciate the talent that CCP has on the team as well.
CCP Snorlax and CCP Karkur thanks for your continued efforts!
|
Yunaride
The Cruciform Keep Calm and Parley
0
|
Posted - 2017.02.18 23:47:47 -
[59] - Quote
thank you for sharing. this attitude towards your payer base is really unique and simply awesome. |
Mara Pahrdi
The Order of Anoyia
1496
|
Posted - 2017.03.04 10:00:52 -
[60] - Quote
+x to CCP Snorlax and thanks for sharing.
Great read.
Remove standings and insurance.
|
|
|
|
|
Pages: 1 [2] 3 :: one page |
First page | Previous page | Next page | Last page |