Pages: [1] 2 :: one page |
|
Author |
Thread Statistics | Show CCP posts - 8 post(s) |
|
CCP FoxFour
C C P C C P Alliance
3547
|
Posted - 2014.10.09 08:47:00 -
[1] - Quote
Hey guys,
I am working on a few updates to the CharacterSheet private data and there have been requests to include all the implants your character has instead of just the attribute ones. For reference this is how the endpoint currently returns implants: http://pastebin.com/BVqWfy4s
The problem with this setup is that it is very much tailored to attribute implants (memory, intelligence, willpower, charisma, and perception).
Adding in the other implants to this area would be very messy.
I could on the other hand completely revamp the implants section to just be a list of typeIDs and leave it to you guys to do the rest. This is my preferred way of doing it, same along the lines of this: http://pastebin.com/aEMByLh8
It's a lot simpler and very similar to the skills section. It however introduces a huge backwards incompatibility into the API. We have done this once before with the industry jobs stuff, but I wanted to get feedback from you guys about this.
The other option of course is to put both in... but that disgusts me a fair bit... mainly because I know I would never come and clean it up and that makes me sad. CCP FoxFour // Game Designer // @CCP_FoxFour |
|
Steve Ronuken
Fuzzwork Enterprises Vote Steve Ronuken for CSM
3971
|
Posted - 2014.10.09 09:00:00 -
[2] - Quote
I'd suggest:
Add in the new implant section.
Leave in a stub node for the attribute enhancers which won't contain data, but will stop things from breaking. (maybe)
And add something to your calendar to remove it later. Woo! CSM 9! http://fuzzwork.enterprises/ Twitter: @fuzzysteve on Twitter |
Sentient Blade
Crisis Atmosphere
1378
|
Posted - 2014.10.09 09:00:00 -
[3] - Quote
The route of adding both may be "eugh" but it is most likely the optimal route to go down IMO. It would leave the existing data in tact and still reflect accurate information for applications which may not keep their static dump immediately up to date or that only wish to include a partial dump of skills related items which might otherwise miss a new typeID, such as the new-grade implants.
Your example implant node looks fine - personally I'd throw in which implant slot it was bound to just for ease-of-use.
|
Darkblad
Hilfe is like free Entertainment
555
|
Posted - 2014.10.09 09:02:00 -
[4] - Quote
Being just a stupid dabbler, I would propose something like this:
https://api.eveonline.com/char/CharacterSheet.xml.aspx?keyID=[]&vCode=[]&characterID=[]&version=2
with the api answering with the current format when version=2 is missing, a bit like eve/AllianceList. Current tools accessing the api won't break immediately and you can mess around with extend the new format.
But again, I'm just ... EVE Infolinks -+-áOld and new-áPortraits |
Desmont McCallock
407
|
Posted - 2014.10.09 09:13:00 -
[5] - Quote
I can totally relate to your concerns. Looking at the pros and cons of the available options, I would vote for total replacing the "attributeEnhancers" section with the "Implants". Just add also typeName in each row. |
Hanazava Karyna
The Foundation Of Mammon
11
|
Posted - 2014.10.09 09:21:00 -
[6] - Quote
Quote:The input may not contain HTML. goddamit.
Here, there is draft http://pastebin.com/CBPKNG5B Should cover pretty much everything. Please ignore second 6th slot implant |
Drailen
New Eden Technology Services
56
|
Posted - 2014.10.09 09:54:00 -
[7] - Quote
Somewhat related, but instead of changing the current character sheet, would it be possible to create a new endpoint which provides all implants for all a character's jump clones (and provide jump clone specific info while doing so)? |
Max Kolonko
High Voltage Industries Ash Alliance
456
|
Posted - 2014.10.09 10:29:00 -
[8] - Quote
CCP FoxFour wrote:Hey guys, I am working on a few updates to the CharacterSheet private data and there have been requests to include all the implants your character has instead of just the attribute ones. For reference this is how the endpoint currently returns implants: http://pastebin.com/BVqWfy4sThe problem with this setup is that it is very much tailored to attribute implants (memory, intelligence, willpower, charisma, and perception). Adding in the other implants to this area would be very messy. I could on the other hand completely revamp the implants section to just be a list of typeIDs and leave it to you guys to do the rest. This is my preferred way of doing it, same along the lines of this: http://pastebin.com/aEMByLh8It's a lot simpler and very similar to the skills section. It however introduces a huge backwards incompatibility into the API. We have done this once before with the industry jobs stuff, but I wanted to get feedback from you guys about this. The other option of course is to put both in... but that disgusts me a fair bit... mainly because I know I would never come and clean it up and that makes me sad.
Type ids should be fine. While you at it pls remember that we will want to have jump cooldown and fatigue in not very distant future visible via api
Read and support: Don't mess with OUR WH's What is Your stance on WH stuff? |
|
CCP FoxFour
C C P C C P Alliance
3549
|
Posted - 2014.10.09 10:38:00 -
[9] - Quote
Max Kolonko wrote:CCP FoxFour wrote:Hey guys, I am working on a few updates to the CharacterSheet private data and there have been requests to include all the implants your character has instead of just the attribute ones. For reference this is how the endpoint currently returns implants: http://pastebin.com/BVqWfy4sThe problem with this setup is that it is very much tailored to attribute implants (memory, intelligence, willpower, charisma, and perception). Adding in the other implants to this area would be very messy. I could on the other hand completely revamp the implants section to just be a list of typeIDs and leave it to you guys to do the rest. This is my preferred way of doing it, same along the lines of this: http://pastebin.com/aEMByLh8It's a lot simpler and very similar to the skills section. It however introduces a huge backwards incompatibility into the API. We have done this once before with the industry jobs stuff, but I wanted to get feedback from you guys about this. The other option of course is to put both in... but that disgusts me a fair bit... mainly because I know I would never come and clean it up and that makes me sad. Type ids should be fine. While you at it pls remember that we will want to have jump cooldown and fatigue in not very distant future visible via api
Already added internally. ;) CCP FoxFour // Game Designer // @CCP_FoxFour |
|
|
CCP FoxFour
C C P C C P Alliance
3549
|
Posted - 2014.10.09 10:38:00 -
[10] - Quote
Drailen wrote:Somewhat related, but instead of changing the current character sheet, would it be possible to create a new endpoint which provides all implants for all a character's jump clones (and provide jump clone specific info while doing so)?
http://pastebin.com/tGmwJMwH
I just added it to the character endpoint... didn't seem like it needed a whole new endpoint. CCP FoxFour // Game Designer // @CCP_FoxFour |
|
|
Drailen
New Eden Technology Services
57
|
Posted - 2014.10.09 10:52:00 -
[11] - Quote
Awesome stuff |
|
CCP FoxFour
C C P C C P Alliance
3550
|
Posted - 2014.10.09 10:59:00 -
[12] - Quote
Here is a sample of how the endpoint looks now: http://pastebin.com/873Eyhi9 CCP FoxFour // Game Designer // @CCP_FoxFour |
|
hfo df
Ramm's RDI Tactical Narcotics Team
23
|
Posted - 2014.10.09 11:12:00 -
[13] - Quote
Nice!
(Also thank you for learning me you can actually name JCs apparently.) |
Querns
GBS Logistics and Fives Support Goonswarm Federation
860
|
Posted - 2014.10.09 13:11:00 -
[14] - Quote
Looks like we are on the right path here, but I wanna echo that adding new fields into the endpoint while leaving the old ones intact is the way to go. Any sane implementation should be able to ignore the new fields while it waits for its developer to update the code.
Glad to see jump clones getting added too! Great stuff all around. This post was crafted by the wormhole expert of the Goonswarm Economic Warfare Cabal, the foremost authority on Eve: Online economics and gameplay. |
|
CCP FoxFour
C C P C C P Alliance
3550
|
Posted - 2014.10.09 13:37:00 -
[15] - Quote
The changes have been deployed to Sisi. CCP FoxFour // Game Designer // @CCP_FoxFour |
|
|
CCP FoxFour
C C P C C P Alliance
3550
|
Posted - 2014.10.09 13:38:00 -
[16] - Quote
Querns wrote:Looks like we are on the right path here, but I wanna echo that adding new fields into the endpoint while leaving the old ones intact is the way to go. Any sane implementation should be able to ignore the new fields while it waits for its developer to update the code.
Glad to see jump clones getting added too! Great stuff all around.
While I agree that would be nice, it means leaving a lot of extra code and DB procs around. So while it would most definitely be nicer for you guys, in order to keep the code base not a complete mess I think this needs to be done. :( CCP FoxFour // Game Designer // @CCP_FoxFour |
|
Sentient Blade
Crisis Atmosphere
1378
|
Posted - 2014.10.09 14:27:00 -
[17] - Quote
If pulling 5 rows from the DB creates a significant problem either from the DB or the code then it would suggest there are much bigger issues at play =\ |
|
CCP FoxFour
C C P C C P Alliance
3550
|
Posted - 2014.10.09 14:30:00 -
[18] - Quote
Sentient Blade wrote:If pulling 5 rows from the DB creates a significant problem either from the DB or the code then it would suggest there are much bigger issues at play =\
It's not a performance issue, it's an issue of keeping a clean code base and not having it become a giant mess. CCP FoxFour // Game Designer // @CCP_FoxFour |
|
Garai Nolen
Xyjax
26
|
Posted - 2014.10.09 14:34:00 -
[19] - Quote
CCP FoxFour wrote:I could on the other hand completely revamp the implants section to just be a list of typeIDs and leave it to you guys to do the rest. This is my preferred way of doing it, same along the lines of this: http://pastebin.com/aEMByLh8
+1 for this. It's backwards incompatible for the right reasons in the right way and I'd much rather have this style sooner (and permanently) than some other much more complicated hybrid solution later.
EVEoj - EVE Online JavaScript library: http://eve-oj.xyjax.com/ |
Desmont McCallock
407
|
Posted - 2014.10.09 16:25:00 -
[20] - Quote
OK, you will hate me for this CCP FoxFour but while we are at it, is there any change we can also get a reference for the "Standard Cerebral Accelerator" booster that so many EVEMon users complain about? (/me runs to hide) |
|
Valterra Craven
290
|
Posted - 2014.10.09 18:29:00 -
[21] - Quote
CCP FoxFour wrote:Sentient Blade wrote:If pulling 5 rows from the DB creates a significant problem either from the DB or the code then it would suggest there are much bigger issues at play =\ It's not a performance issue, it's an issue of keeping a clean code base and not having it become a giant mess.
I support doing it right the first time. We don't need to relive the POS code excuses in other systems 5 years down the road. |
Dragonaire
Here there be Dragons
63
|
Posted - 2014.10.09 20:07:00 -
[22] - Quote
I like the change even if it does mean I'll be having to update Yapeal to account for the new structure. I do have a question on how the lastRespecDate and lastTimedRespec are used. They would seem to be one and the same thing almost but I'm guess they aren't. Maybe a little different naming would help to make their propose clearer. Or at least some clarification on what they mean. Finds camping stations from the inside much easier. Designer of Yapeal-á for the Eve API. Check out the Yapeal PHP API Library thread for more information. |
Dragonaire
Here there be Dragons
63
|
Posted - 2014.10.09 21:22:00 -
[23] - Quote
oh one other thing can you make sure all the rowsets are after all of the other elements and not like your example with balance hiding out down in the middle it'll make things much easier for everyone trying to parse it I haven't had a chance to try it on the test server to see if it works that way but if not moved that would make it much harder to work with I think. Finds camping stations from the inside much easier. Designer of Yapeal-á for the Eve API. Check out the Yapeal PHP API Library thread for more information. |
Steve Ronuken
Fuzzwork Enterprises Vote Steve Ronuken for CSM
3984
|
Posted - 2014.10.09 21:35:00 -
[24] - Quote
Dragonaire wrote:oh one other thing can you make sure all the rowsets are after all of the other elements and not like your example with balance hiding out down in the middle it'll make things much easier for everyone trying to parse it I haven't had a chance to try it on the test server to see if it works that way but if not moved that would make it much harder to work with I think.
Surely if you're treating it as XML, it really doesn't matter where the data is?
You can either iterate through it, dealing with each segment with an appropriate callback, or use xpath to pull the relevant sections? Woo! CSM 9! http://fuzzwork.enterprises/ Twitter: @fuzzysteve on Twitter |
Dragonaire
Here there be Dragons
63
|
Posted - 2014.10.10 02:40:00 -
[25] - Quote
I validate it with XSD and it tends to care about order things are in plus there a couple other reasons that are particular to Yapeal that make it nicer to be better ordered. I have ways to work around if need be. There's also the not messing with people that have CDO (OCD) factor to consider Finds camping stations from the inside much easier. Designer of Yapeal-á for the Eve API. Check out the Yapeal PHP API Library thread for more information. |
Slvrsmth
TeamAXE inc.
17
|
Posted - 2014.10.10 07:17:00 -
[26] - Quote
A list of typeIDs seems to be a great general solution.
Breakage could be avoiding by including this new block now, and then announcing a date when old one will be removed. Say, three months? Should be enough for the actively developed applications to get updated, and push the changes to their users. That could also accommodate slow rollouts (ex: mobile applications), because both old and new code paths should be able to work in the 'grace period'.
But really, you want API versioning. Aggressively retiring old versions if you wish for the code base to remain compact, but in the long run it's very much worth it. Carebearium - find the best solar system for you! |
Steve Ronuken
Fuzzwork Enterprises Vote Steve Ronuken for CSM
3986
|
Posted - 2014.10.10 09:01:00 -
[27] - Quote
Dragonaire wrote:I validate it with XSD and it tends to care about order things are in plus there a couple other reasons that are particular to Yapeal that make it nicer to be better ordered. I have ways to work around if need be. There's also the not messing with people that have CDO (OCD) factor to consider
Ahh.
Thanks I was wondering. Woo! CSM 9! http://fuzzwork.enterprises/ Twitter: @fuzzysteve on Twitter |
Desmont McCallock
408
|
Posted - 2014.10.12 08:17:00 -
[28] - Quote
I decided today to have a look on the changes made that are live on Sisi and it made me extremely happy to find out that they didn't broke EVEMon \o/ (partially because we have done a good job with the code on our side too). Now lets dive into it and implement the changes so we are ready when it goes live on TQ. |
Desmont McCallock
408
|
Posted - 2014.10.12 12:12:00 -
[29] - Quote
@CCP FoxFour I'm not seeing any implant reference in the implants rowset for slots 6-10. The jumpCloneImplants have them though. |
|
CCP FoxFour
C C P C C P Alliance
3559
|
Posted - 2014.10.12 12:46:00 -
[30] - Quote
Desmont McCallock wrote:@CCP FoxFour I'm not seeing any implant reference in the implants rowset for slots 6-10. The jumpCloneImplants have them though.
Thanks, I actually didn't test those implants. Will take a look on Monday. CCP FoxFour // Game Designer // @CCP_FoxFour |
|
|
|
|
|
Pages: [1] 2 :: one page |
First page | Previous page | Next page | Last page |